[chore]: use ErrorContains and EqualError #11295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11295 +/- ##
=======================================
Coverage 91.47% 91.47%
=======================================
Files 424 424
Lines 20219 20219
=======================================
Hits 18495 18495
Misses 1341 1341
Partials 383 383 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
testify/error-contains
branch
from
ba8344d
to
732bb6d
Compare
bogdandrutu
approved these changes
Sep 28, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
#### Description Testifylint doesn't support it yet. This replaces `Contains(t, err.Error()` by `ErrorContains(t, err` and `Equal(t, err.Error()` by `EqualError(t, err` As they both check for nil error it becomes useless to check it yourself without having defined a custom message <!-- Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> --> Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testifylint doesn't support it yet.
This replaces
Contains(t, err.Error()byErrorContains(t, errandEqual(t, err.Error()byEqualError(t, errAs they both check for nil error it becomes useless to check it yourself without having defined a custom message